Skip to content

docs(tutorial/github_actions): suggest using pypi api token #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 20, 2020

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          33       33           
  Lines         785      785           
=======================================
  Hits          721      721           
  Misses         64       64           
Flag Coverage Δ
#unittests 91.84% <100.00%> (ø)
Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bd2f0...de6a25e. Read the comment docs.

@Lee-W Lee-W merged commit 985f391 into master Apr 20, 2020
Go to `Settings > Secrets > Add new secret` and add the secrets: `PYPI_USERNAME` and `PYPI_PASSWORD`.
Instead of using username and password, we suggest using [api token](https://pypi.org/help/#apitoken) generated from PyPI.

After generate api token, use the token as the PyPI password and `__token__` as the username.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I read the docs and the twine github action correctly, the password should have a pypi- prefix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it's included as you generate the api token.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@Lee-W Lee-W deleted the weilee/update-publish-doc branch April 20, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants